Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, V Sowmya.
Subrata Banik has posted comments on this change by V Sowmya. ( https://review.coreboot.org/c/coreboot/+/84420?usp=email )
Change subject: mb/google/nissa/var/nivviks: Update the power resource for NVM and VCM
......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/brya/variants/nivviks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84420/comment/9301bae6_37df35ea?usp... :
PS1, Line 512: chip drivers/sof
: register "spkr_tplg" = "max98360a"
: register "jack_tplg" = "nau8825"
: register "mic_tplg" = "_2ch_pdm0"
: device generic 0 on end
: end
Apologies for oversight and i have reverted the change.
Acknowledged
https://review.coreboot.org/c/coreboot/+/84420/comment/cf600abb_bfb04d57?usp... :
PS1, Line 449: E(1, 0)"
Off/Disable sequence is gpio[1] -> gpio[0] (Its done in same sequence for camera sensor also)
Acknowledged
https://review.coreboot.org/c/coreboot/+/84420/comment/9189ccc0_704b24ae?usp... :
PS1, Line 450: "SEQ_OPS_GPIO_DISABLE(0, 0)"
Off/Disable sequence is gpio[1] -> gpio[0]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84420?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id3e256d59982ac176844e289f18ee450079704b9
Gerrit-Change-Number: 84420
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 19 Sep 2024 08:30:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: V Sowmya
v.sowmya@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com