Attention is currently required from: Jakub Czapiga. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55397 )
Change subject: cbtable: Store loglevel with consoles ......................................................................
Patch Set 7:
(1 comment)
File tests/stubs/console.c:
https://review.coreboot.org/c/coreboot/+/55397/comment/4516a32c_fbd8dc13 PS4, Line 23: bool fast_consoles_only(void)
I would make it __weak to allow mocking of this function. […]
We don't need it anymore, so this point is moot. For completeness though, all functions listed in $(test)-mocks are marked weak by objcopy before presenting the alternatives, thereby replacing them with the mocks. So the fix would have been to add a -mocks entry.
-
Patrick Georgi (Code Review)