Attention is currently required from: Krystian Hebel, Michał Kopeć, Michał Żygowski, Sergii Dmytruk.
Maximilian Brune has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82639?usp=email )
Change subject: mb/qemu-{i440fx,q35}: reduce default ROM size to 8 MiB
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/mainboard/emulation/qemu-q35/Kconfig:
https://review.coreboot.org/c/coreboot/+/82639/comment/e5b80e4d_ec200e14?usp... :
PS6, Line 13: select BOARD_ROMSIZE_KB_8192
It is still possible, just add `CONFIG_COREBOOT_ROMSIZE_KB_16384=y` to defconfig. […]
My bad. I didn't realize we already have user configurable configurable `CONFIG_COREBOOT_ROMSIZE_KB_...` options for that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82639?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If36cb754a8e75e23bce49ff568dd88e5db279bb8
Gerrit-Change-Number: 82639
Gerrit-PatchSet: 6
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Tue, 13 Aug 2024 18:45:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com