Attention is currently required from: Karthik Ramasubramanian, Boris Mittelberg.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56840 )
Change subject: mb/google/dedede: allow MKBP devices
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56840/comment/7a20fccd_fc756fd3
PS1, Line 9: Enable MKBP interface for all dedede family to use for buttons and switches
Please add a dot/period at the end of sentences.
https://review.coreboot.org/c/coreboot/+/56840/comment/30e64969_e34c0bb8
PS1, Line 12: TEST=manual test on Madoo
What (button/switch) did you test exactly?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d1f43e4dd56318af4c1d5f5c1c3a2c237a05c5f
Gerrit-Change-Number: 56840
Gerrit-PatchSet: 1
Gerrit-Owner: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aseda Aboagye
aaboagye@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Fri, 06 Aug 2021 07:41:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment