Change in coreboot[master]: mb/google/dedede/var/galtic: update Wifi SAR for convertibles
Attention is currently required from: Henry Sun, Frank Chu, Zhuohao Lee, Karthik Ramasubramanian. Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58734 )
Change subject: mb/google/dedede/var/galtic: update Wifi SAR for convertibles ......................................................................
Patch Set 6:
(4 comments)
File src/mainboard/google/dedede/variants/galtic/variant.c:
https://review.coreboot.org/c/coreboot/+/58734/comment/c25eb494_cd7800a0 PS6, Line 23: return "wifi_sar-galtic.hex";
sorry, could I know why default sar file recommend to use galtic sar file? […]
Oh, just because in original code, galtic was returned so I think the default one would be galtic. But it should be fine if you set galith is the default one in CL:3267913
https://review.coreboot.org/c/coreboot/+/58734/comment/cdbc8b21_f1ace713 PS6, Line 27: galith
According to the result of RF measurement, both of galith/gallop wifi sar table is the same
As you mentioned, if galith is the default SAR table defined in CL:3267913 then you can just have line 32 to return WIFI_SAR_CBFS_DEFAULT_FILENAME and remove line 24 ~ 27?
https://review.coreboot.org/c/coreboot/+/58734/comment/aa54f675_4782a657 PS6, Line 31: return "wifi_sar-galith360.hex"; nit: a new line before line 32 please.
https://review.coreboot.org/c/coreboot/+/58734/comment/b7c32c24_b7589e41 PS6, Line 32: return "WIFI_SAR_CBFS_DEFAULT_FILENAME";
By the way, WIFI_SAR_CBFS_DEFAULT_FILENAME should be returned instead of "WIFI_SAR_CBFS_DEFAULT_FILENAME"?
-
Marco Chen (Code Review)