Change in ...coreboot[master]: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien"

List overview All Threads
Download

newer

older

Change in ...libgfxinit[master]:...

Change in ...coreboot[master]:...

Li1 Feng (Code Review)

6 Apr 2019 6 Apr '19

4:36 a.m.

Hello Jett Rink, Jett Rink, Duncan Laurie, build bot (Jenkins), Patrick Georgi,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/32218

to review the following change.

Change subject: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien"

This reverts commit b0c726b683bf52fd94250d18aa4c3f78e6622fca.

Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb M src/mainboard/google/sarien/variants/sarien/devicetree.cb 2 files changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32218/1

diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 93e0af9..54308e1 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -113,7 +113,6 @@ device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS device pci 12.6 off end # GSPI #2 - device pci 13.0 on end # Integrated Sensor Hub device pci 14.0 on chip drivers/usb/acpi register "desc" = ""Root Hub"" diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index d25e725..6afc13c 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -113,7 +113,7 @@ device pci 12.0 on end # Thermal Subsystem device pci 12.5 off end # UFS SCS device pci 12.6 off end # GSPI #2 - device pci 13.0 off end # Integrated Sensor Hub + device pci 13.0 on end # Integrated Sensor Hub device pci 14.0 on chip drivers/usb/acpi register "desc" = ""Root Hub""

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 1 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newchange

Attachments:

attachment.htm (text/html — 4.0 KB)

Show replies by date

Jett Rink (Code Review)

6 Apr 6 Apr

6:27 a.m.

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32218 )

Change subject: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Patch Set 1:

Why are we reverting this CL?

Li1 Feng (Code Review)

6:56 a.m.

Li1 Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32218 )

Change subject: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Patch Set 1:

Test purpose. This is request from PNP team, they want to measure power without ISH.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 1 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 05 Apr 2019 21:56:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Li1 Feng (Code Review)

8:28 a.m.

Hello Jett Rink, Jett Rink, Duncan Laurie, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32218

to look at the new patch set (#2).

Change subject: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien"

This reverts commit b0c726b683bf52fd94250d18aa4c3f78e6622fca.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32218/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 2 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Li1 Feng (Code Review)

8:30 a.m.

Hello Jett Rink, Jett Rink, Duncan Laurie, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32218

to look at the new patch set (#3).

Change subject: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien"

This reverts commit b0c726b683bf52fd94250d18aa4c3f78e6622fca.

Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32218/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 3 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

8 Apr 8 Apr

8:32 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32218 )

Change subject: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32218/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32218/3//COMMIT_MSG@10 PS3, Line 10: Why?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 3 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 08 Apr 2019 11:32:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jett Rink (Code Review)

10:26 p.m.

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32218 )

Change subject: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Patch Set 3:

Please update the CL description to say this is for testing only, otherwise it is confusing to other people that see this revert and think something is wrong.

Also is there a reason you uploaded this change instead of carrying it locally?

Performing this change on the chromium tree of coreboot would probably be more effective for testing purposes as that is what actually builds (https://chromium.git.corp.google.com/chromiumos/third_party/coreboot/+/refs/...)

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 3 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 08 Apr 2019 13:26:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Li1 Feng (Code Review)

9 Apr 9 Apr

1:23 a.m.

New subject: Change in ...coreboot[master]: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sa...

Hello Jett Rink, Jett Rink, Duncan Laurie, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32218

to look at the new patch set (#4).

Change subject: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien"

This reverts commit b0c726b683bf52fd94250d18aa4c3f78e6622fca.

Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32218/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 4 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Li1 Feng (Code Review)

1:24 a.m.

New subject: Change in ...coreboot[master]: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sa...

Li1 Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32218 )

Change subject: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32218/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32218/3//COMMIT_MSG@10 PS3, Line 10:

...

Why?

Sorry for the confusion. This is only for internal to collect power data. Testing only.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 4 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 08 Apr 2019 16:24:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Li1 Feng (Code Review)

1:45 a.m.

New subject: Change in ...coreboot[master]: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sa...

Li1 Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32218 )

Change subject: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Patch Set 4:

Updated description. This is for Jenkins to build, which polls the source code and patches from open source git.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 4 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 08 Apr 2019 16:45:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Lijian Zhao (Code Review)

4:36 a.m.

New subject: Change in ...coreboot[master]: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sa...

Lijian Zhao has uploaded a new patch set (#5) to the change originally created by Li1 Feng. ( https://review.coreboot.org/c/coreboot/+/32218 )

Change subject: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien"

This reverts commit b0c726b683bf52fd94250d18aa4c3f78e6622fca.

Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Signed-off-by: Lijian Zhao lijian.zhao@intel.com --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32218/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 5 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Lijian Zhao (Code Review)

5:55 a.m.

New subject: Change in ...coreboot[master]: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sa...

Lijian Zhao has uploaded a new patch set (#6) to the change originally created by Li1 Feng. ( https://review.coreboot.org/c/coreboot/+/32218 )

Change subject: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien"

This reverts commit b0c726b683bf52fd94250d18aa4c3f78e6622fca.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/32218/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 6 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Jett Rink (Code Review)

29 Apr 29 Apr

10:27 p.m.

New subject: Change in ...coreboot[master]: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sa...

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32218 )

Change subject: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Patch Set 6:

Can we revert this CL now?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 6 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Apr 2019 13:27:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Li1 Feng (Code Review)

30 Apr 30 Apr

4:14 a.m.

New subject: Change in ...coreboot[master]: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sa...

Li1 Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32218 )

Change subject: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Patch Set 6:

It's not merged. Is abandon the patch OK?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 6 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Apr 2019 19:14:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jett Rink (Code Review)

4:42 a.m.

New subject: Change in ...coreboot[master]: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sa...

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32218 )

Change subject: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Patch Set 6:

...

Patch Set 6:

It's not merged. Is abandon the patch OK?

Yes, let;s abandon it. Thanks!

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 6 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 29 Apr 2019 19:42:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Li1 Feng (Code Review)

5:43 a.m.

New subject: Change in ...coreboot[master]: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sa...

Li1 Feng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32218 )

Change subject: arcada: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien" ......................................................................

Abandoned

test is done. no need anymore.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32218 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da Gerrit-Change-Number: 32218 Gerrit-PatchSet: 6 Gerrit-Owner: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Li1 Feng li1.feng@intel.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1986

days inactive

2010

days old

coreboot-gerrit@coreboot.org

15 comments

4 participants

tags (0)

participants (4)

Jett Rink (Code Review)
Li1 Feng (Code Review)
Lijian Zhao (Code Review)
Paul Menzel (Code Review)