Change in coreboot[master]: util/cbfstool/amdcompress: fix argument requirement

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47573 )

Change subject: util/cbfstool/amdcompress: fix argument requirement
......................................................................

util/cbfstool/amdcompress: fix argument requirement

The compress and uncompress options don't have arguments and shouldn't
consume the next token. So replace required_argument with no_argument
for the two options.

Change-Id: Ib9b190f2cf606109f82a65d00327871d6ffb7082
Signed-off-by: Felix Held 
---
M util/cbfstool/amdcompress.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/47573/1

diff --git a/util/cbfstool/amdcompress.c b/util/cbfstool/amdcompress.c
index b4e10a2..eae347f 100644
--- a/util/cbfstool/amdcompress.c
+++ b/util/cbfstool/amdcompress.c
@@ -29,9 +29,9 @@
 static struct option long_options[] = {
    {"infile",           required_argument, 0, 'i' },
    {"outfile",          required_argument, 0, 'o' },
-	{"compress",         required_argument, 0, 'c' },
+	{"compress",         no_argument, 	0, 'c' },
    {"maxsize",          required_argument, 0, 'h' },
-	{"uncompress",       required_argument, 0, 'u' },
+	{"uncompress",       no_argument, 	0, 'u' },
    {"help",             no_argument,       0, 'h' },
 };

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47573 )

Change subject: util/cbfstool/amdcompress: fix argument requirement
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/47573/1/util/cbfstool/amdcompress.c 
File util/cbfstool/amdcompress.c:

https://review.coreboot.org/c/coreboot/+/47573/1/util/cbfstool/amdcompress.c... 
PS1, Line 32: 	{"compress",         no_argument, 	0, 'c' },
please, no space before tabs

https://review.coreboot.org/c/coreboot/+/47573/1/util/cbfstool/amdcompress.c... 
PS1, Line 34: 	{"uncompress",       no_argument, 	0, 'u' },
please, no space before tabs

[Felix Held (Code Review)]

Hello Jason Glenesk, Furquan Shaikh, Marshall Dawson, Jeremy Soller, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47573

to look at the new patch set (#2).

Change subject: util/cbfstool/amdcompress: fix argument requirement
......................................................................

util/cbfstool/amdcompress: fix argument requirement

The compress and uncompress options don't have arguments and shouldn't
consume the next token. So replace required_argument with no_argument
for the two options.

Change-Id: Ib9b190f2cf606109f82a65d00327871d6ffb7082
Signed-off-by: Felix Held 
---
M util/cbfstool/amdcompress.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/47573/2

[Felix Held (Code Review)]

Hello build bot (Jenkins), Jason Glenesk, Furquan Shaikh, Marshall Dawson, Jeremy Soller, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47573

to look at the new patch set (#4).

Change subject: util/cbfstool/amdcompress: fix argument requirement
......................................................................

util/cbfstool/amdcompress: fix argument requirement

The compress and uncompress options don't have arguments and shouldn't
consume the next token. So replace required_argument with no_argument
for the two options.

Change-Id: Ib9b190f2cf606109f82a65d00327871d6ffb7082
Signed-off-by: Felix Held 
---
M util/cbfstool/amdcompress.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/47573/4

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47573 )

Change subject: util/cbfstool/amdcompress: fix argument requirement
......................................................................

Patch Set 4: Code-Review+1

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47573 )

Change subject: util/cbfstool/amdcompress: fix argument requirement
......................................................................

Patch Set 4: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47573 )

Change subject: util/cbfstool/amdcompress: fix argument requirement
......................................................................

util/cbfstool/amdcompress: fix argument requirement

The compress and uncompress options don't have arguments and shouldn't
consume the next token. So replace required_argument with no_argument
for the two options.

Change-Id: Ib9b190f2cf606109f82a65d00327871d6ffb7082
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47573
Tested-by: build bot (Jenkins) 
Reviewed-by: Kyösti Mälkki 
Reviewed-by: Marshall Dawson 
---
M util/cbfstool/amdcompress.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, but someone else must approve
  Marshall Dawson: Looks good to me, approved

diff --git a/util/cbfstool/amdcompress.c b/util/cbfstool/amdcompress.c
index ad6a039..76089ea 100644
--- a/util/cbfstool/amdcompress.c
+++ b/util/cbfstool/amdcompress.c
@@ -29,9 +29,9 @@
 static struct option long_options[] = {
    {"infile",           required_argument, 0, 'i' },
    {"outfile",          required_argument, 0, 'o' },
-	{"compress",         required_argument, 0, 'c' },
+	{"compress",         no_argument,       0, 'c' },
    {"maxsize",          required_argument, 0, 'm' },
-	{"uncompress",       required_argument, 0, 'u' },
+	{"uncompress",       no_argument,       0, 'u' },
    {"help",             no_argument,       0, 'h' },
 };