[L] Change in coreboot[main]: mb/google/fatcat: Add GPIO settings - coreboot-gerrit

20 Sep 2024


      Attention is currently required from: Jérémy Compostella, Pranava Y N, Subrata Banik.
Cliff Huang has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84405?usp=email )
Change subject: mb/google/fatcat: Add GPIO settings
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/gpio.c:
https://review.coreboot.org/c/coreboot/+/84405/comment/2b7147e6_ed7b752d?usp... :
PS1, Line 440: 	/* GPP_C05:     CRD1_PWREN */
...
I don't think we are using CRD1, please don't keep everyone power on by default which will have an i […]
This is used for world facing camera.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84405?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d52
Gerrit-Change-Number: 84405
Gerrit-PatchSet: 6
Gerrit-Owner: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Pranava Y N pranavayn@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Cliff Huang cliff.huang@intel.com
Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Pranava Y N pranavayn@google.com
Gerrit-Comment-Date: Thu, 19 Sep 2024 22:16:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com