Change in coreboot[master]: mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Michael Niewöhner (Code Review)

20 Oct 2019 20 Oct '19

12:02 a.m.

Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36141 )

Change subject: mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does ......................................................................

mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does

This enables SLP_S0 for x11 boards.

Change-Id: I7240ed631bf72b1d3c9ea887da43772781c80b45 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/devicetree.cb 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/36141/1

diff --git a/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb b/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb index ee6aac7..5a99e7a 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb +++ b/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb @@ -98,7 +98,8 @@ # LPC register "serirq_mode" = "SERIRQ_CONTINUOUS"

- # Enabling SLP_S3#, SLP_S4#, SLP_SUS and SLP_A Stretch + # Enabling SLP_S0, SLP_S3#, SLP_S4#, SLP_SUS and SLP_A Stretch + register "s0ix_enable" = "1" register "PmConfigSlpS3MinAssert" = "SLP_S3_MIN_ASSERT_50MS" register "PmConfigSlpS4MinAssert" = "SLP_S4_MIN_ASSERT_4S" register "PmConfigSlpSusMinAssert" = "SLP_SUS_MIN_ASSERT_4S"

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Michael Niewöhner (Code Review)

20 Oct 20 Oct

12:07 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36141 )

Change subject: mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does ......................................................................

Patch Set 1:

@Patrick Rudolph: can you verify on x11ssh-tf that SLP_S0 is enabled there, too? register is PWRMBASE+0x31C[15]

-- To view, visit https://review.coreboot.org/c/coreboot/+/36141 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7240ed631bf72b1d3c9ea887da43772781c80b45 Gerrit-Change-Number: 36141 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Sat, 19 Oct 2019 22:07:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

22 Oct 22 Oct

3:55 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36141 )

Change subject: mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does ......................................................................

Patch Set 1: Code-Review+1

...

Patch Set 1:

@Patrick Rudolph: can you verify on x11ssh-tf that SLP_S0 is enabled there, too? register is PWRMBASE+0x31C[15]

verified on x11ssh by inteltool dump

-- To view, visit https://review.coreboot.org/c/coreboot/+/36141 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7240ed631bf72b1d3c9ea887da43772781c80b45 Gerrit-Change-Number: 36141 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 22 Oct 2019 13:55:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

23 Oct 23 Oct

8:47 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36141 )

Change subject: mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36141 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7240ed631bf72b1d3c9ea887da43772781c80b45 Gerrit-Change-Number: 36141 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 23 Oct 2019 06:47:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

1:46 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36141 )

Change subject: mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36141/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36141/1//COMMIT_MSG@10 PS1, Line 10: What does it do? Did you test with GNU/Linux that s0ix(?) works?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36141 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7240ed631bf72b1d3c9ea887da43772781c80b45 Gerrit-Change-Number: 36141 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 23 Oct 2019 11:46:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

3:25 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36141 )

Change subject: mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36141/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36141/1//COMMIT_MSG@10 PS1, Line 10:

...

What does it do? Did you test with GNU/Linux that s0ix(?) works?

Yep, tested successfully. s0ix enables assertion of SLP_S0, which tells external components (like power supply, power regulators, ...) to switch into a low power idle mode for saving power. See this for example: https://www.richtek.com/assets/product_file/RT5074A/DS5074A-00.pdf

-- To view, visit https://review.coreboot.org/c/coreboot/+/36141 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7240ed631bf72b1d3c9ea887da43772781c80b45 Gerrit-Change-Number: 36141 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 23 Oct 2019 13:25:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Nico Huber (Code Review)

4:02 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36141 )

Change subject: mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36141/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36141/1//COMMIT_MSG@10 PS1, Line 10:

...

Yep, tested successfully. […]

Curious, how much power does it save?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36141 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7240ed631bf72b1d3c9ea887da43772781c80b45 Gerrit-Change-Number: 36141 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 23 Oct 2019 14:02:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

9:26 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36141 )

Change subject: mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36141/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36141/1//COMMIT_MSG@10 PS1, Line 10:

...

Curious, how much power does it save?

I haven't done any measurements, yet

-- To view, visit https://review.coreboot.org/c/coreboot/+/36141 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7240ed631bf72b1d3c9ea887da43772781c80b45 Gerrit-Change-Number: 36141 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 23 Oct 2019 19:26:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

9:26 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36141 )

Change subject: mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36141/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36141/1//COMMIT_MSG@10 PS1, Line 10:

...

I haven't done any measurements, yet

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/36141 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7240ed631bf72b1d3c9ea887da43772781c80b45 Gerrit-Change-Number: 36141 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 23 Oct 2019 19:26:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Patrick Georgi (Code Review)

24 Oct 24 Oct

9:42 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36141 )

Change subject: mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does ......................................................................

mb/supermicro/x11-lga1151-series: enable SLP_S0 as vendor does

This enables SLP_S0 for x11 boards.

Change-Id: I7240ed631bf72b1d3c9ea887da43772781c80b45 Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/36141 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/mainboard/supermicro/x11-lga1151-series/devicetree.cb 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Michael Niewöhner: Looks good to me, but someone else must approve

diff --git a/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb b/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb index b94bee8..1b9dc27 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb +++ b/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb @@ -92,7 +92,8 @@ # LPC register "serirq_mode" = "SERIRQ_CONTINUOUS"

-- To view, visit https://review.coreboot.org/c/coreboot/+/36141 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7240ed631bf72b1d3c9ea887da43772781c80b45 Gerrit-Change-Number: 36141 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1849

days inactive

1854

days old

coreboot-gerrit@coreboot.org

9 comments

5 participants

tags (0)

participants (5)

Michael Niewöhner (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)