Attention is currently required from: Furquan Shaikh, Francois Toguo Fotso, Subrata Banik, Daocheng Bu, Tim Wawrzynczak, Kane Chen, Patrick Rudolph, Karthik Ramasubramanian, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57684 )
Change subject: soc/intel/common: Add PMC Crashlog PCI driver
......................................................................
Patch Set 9:
(3 comments)
Patchset:
PS9:
Thanks for the work! We are working on this feature as well, albeit for Xeon-SP processors.
File src/soc/intel/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/57684/comment/460fc2cd_5a17fdec
PS9, Line 40: crashlog record on every boot.
Do you mean "enables the PMC crashlog driver to collect crashlog records on every reset"? If the PMC crashlog record was cleared prior to last running session, and there was no PMC crash during the last running session, there will be zero PMC crashlog records, correct? In such case, the PMC crashlog driver finds zero crashlog records, and hence BERT table is not populated with PMC crashlog record.
The reason I would like to clarify this is because OS treats BERT table as an error of previous running session, and user gets alerted to investigate. We want to avoid false alarm.
File src/soc/intel/common/block/crashlog/pmc_crashlog.c:
https://review.coreboot.org/c/coreboot/+/57684/comment/667d284d_4e6dd214
PS9, Line 269:
Once crashlog records are collected, should we clear the records?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57684
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc27bbdf35fcd680be224ba0a0e642c94d29bca3
Gerrit-Change-Number: 57684
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Daocheng Bu
daocheng.bu@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Daocheng Bu
daocheng.bu@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 14 Apr 2022 16:27:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment