Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42684 )
Change subject: Revert "mb/pcengines/apu2: Update GPIO Reads & writes" ......................................................................
Patch Set 1:
Patch Set 1:
I thought Picasso team has already decided about the AMD GPIO abstraction layer. I didn't want to block their work and merged the change being reverted here. I will look into this patch series so we can get a more elegant implementation
I mostly need the revert here for build purposes and ease of review on CB:42521. I have that next on my queue, no action expected from you until it is ready for testing.
Designs can be replaced and decisions overruled when/if better approaches arise. The Picasso approach at least currently leaks x86 memory space #defines to psp-verstage and this makes it somewhat errorprone, there is some undesirable forking of sources too. I got some green light from Aaron and Raul to investigate another approach, which this topic:amd-acpimmio-alt will present.