Attention is currently required from: Ravi kumar, Taniya Das, mturney mturney, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58580 )
Change subject: qualcomm/sc7280: gpio: Support eGPIO scheme
......................................................................
Patch Set 7:
(3 comments)
File src/soc/qualcomm/common/gpio.c:
https://review.coreboot.org/c/coreboot/+/58580/comment/21c808b7_b24e5407
PS2, Line 21: if ((read32(®s->cfg) >> GPIO_EGPIO_SHFT) & GPIO_EGPIO_BMSK)
Would this work? […]
Done
File src/soc/qualcomm/common/include/soc/gpio_common.h:
https://review.coreboot.org/c/coreboot/+/58580/comment/271b1ece_9d3ba528
PS6, Line 24: BIT(11)
Let's do 0x800 since everything else is in hex.
Done
File src/soc/qualcomm/common/include/soc/gpio_common.h:
https://review.coreboot.org/c/coreboot/+/58580/comment/97d6772e_79589e2d
PS2, Line 87: enum egpio_cfg {
Yes, we might need to add more fields in future, thus added the enum.
This has been removed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58580
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2598a41ba3bb8a8a2acff8253b5bb78633f89f9
Gerrit-Change-Number: 58580
Gerrit-PatchSet: 7
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Taniya Das
quic_tdas@quicinc.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Taniya Das
quic_tdas@quicinc.com
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 16 Nov 2021 17:26:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Taniya Das
quic_tdas@quicinc.com
Gerrit-MessageType: comment