Attention is currently required from: Nico Huber, Paul Menzel, Angel Pons. Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54380 )
Change subject: kontron/mal10: Set up GPIOs in CPLD/EC ......................................................................
Patch Set 11:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54380/comment/0593e6a3_815477d6 PS10, Line 7: Setup
Nit: The verb is spelled with a space: *set up*.
Thanks! Done
https://review.coreboot.org/c/coreboot/+/54380/comment/d9c1cb9c_39049f21 PS10, Line 15: [1] CB:47595
Please also add the Change-Id.
Done
Patchset:
PS10:
I'm confused. […]
The pin-out table is included in the specification of COMe modules. Please see 4.6 Pinout Tables in "PICMG COM.0 Revision 3.0 COM Express Base Specification - March 31, 2017", Table 4.38: "Pin List for Pin-Out Type 10", page 79 (I also added information about this to the commit message). This configuration should be taken into account when designing the carrier board. Therefore, I would prefer to keep this in the module's device tree.
-
Maxim Polyakov (Code Review)