Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/20238 )
Change subject: [WIP]: add superio driver for sch5545
......................................................................
Patch Set 2:
(1 comment)
Lynxis, any object if Christoph or I rebase this too?
https://review.coreboot.org/c/coreboot/+/20238/1/src/superio/smsc/sch5545/sc...
File src/superio/smsc/sch5545/sch5545_early_init.c:
https://review.coreboot.org/c/coreboot/+/20238/1/src/superio/smsc/sch5545/sc...
PS1, Line 82: uint8_t val = blink && SCH5545_LED_BLINK_MASK;
src/superio/smsc/sch5545/sch5545_early_init.c: In function 'sch5545_set_led':
src/superio/smsc/sch5545/sch5545_early_init.c:82:22: error: logical 'and' applied to non-boolean constant [-Werror=logical-op]
uint8_t val = blink && SCH5545_LED_BLINK_MASK;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/20238
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic258630b02e6ae86b1ee7ce663d9d026bf1c04e9
Gerrit-Change-Number: 20238
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peter Stuge
peter@stuge.se
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Comment-Date: Fri, 17 Jan 2020 16:21:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment