Change in coreboot[master]: google/trogdor: Remove GPIO_AP_SUSPEND_L

[Julius Werner (Code Review)]

Hello Doug Anderson, Philip Chen, Wai-Hong Tam, mturney mturney,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/43471

to review the following change.

Change subject: google/trogdor: Remove GPIO_AP_SUSPEND_L
......................................................................

google/trogdor: Remove GPIO_AP_SUSPEND_L

This pin has been removed from recent revisions (or at least moved to a
pin that's not controlled like a normal GPIO). It has also never been
used on older ones (I think?). The same GPIO is now used as a SKU ID
pin, so make sure we're not incorrectly configuring it as an output
(although sku_id() overrides that later anyway, but it's still
incorrect).

BUG=b:160754995

Signed-off-by: Julius Werner 
Change-Id: I6e0d56e230d0bef172d7b78cc48263e9b6f059de
---
M src/mainboard/google/trogdor/board.h
M src/mainboard/google/trogdor/chromeos.c
2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/43471/1

diff --git a/src/mainboard/google/trogdor/board.h b/src/mainboard/google/trogdor/board.h
index 63d03db..cab4403 100644
--- a/src/mainboard/google/trogdor/board.h
+++ b/src/mainboard/google/trogdor/board.h
@@ -9,7 +9,6 @@

#define GPIO_EC_IN_RW	GPIO(118)
 #define GPIO_AP_EC_INT	GPIO(94)
-#define GPIO_AP_SUSPEND	GPIO(20)
 #define GPIO_WP_STATE	GPIO(42)
 #define GPIO_H1_AP_INT	(CONFIG(TROGDOR_REV0) ? GPIO(21) : GPIO(42))
 #define GPIO_SD_CD_L	GPIO(69)
diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c
index 9360928..9c45dfe 100644
--- a/src/mainboard/google/trogdor/chromeos.c
+++ b/src/mainboard/google/trogdor/chromeos.c
@@ -14,7 +14,6 @@
 {
    gpio_input_pullup(GPIO_EC_IN_RW);
    gpio_input_pullup(GPIO_AP_EC_INT);
-	gpio_output(GPIO_AP_SUSPEND, 1);
    gpio_input(GPIO_WP_STATE);
    gpio_input_pullup(GPIO_SD_CD_L);
    gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP);

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43471 )

Change subject: google/trogdor: Remove GPIO_AP_SUSPEND_L
......................................................................

Patch Set 1: Code-Review+2

[Douglas Anderson (Code Review)]

Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43471 )

Change subject: google/trogdor: Remove GPIO_AP_SUSPEND_L
......................................................................

Patch Set 2: Code-Review+1

[Philip Chen (Code Review)]

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43471 )

Change subject: google/trogdor: Remove GPIO_AP_SUSPEND_L
......................................................................

Patch Set 2: Code-Review+2

[Bob Moragues (Code Review)]

Bob Moragues has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43471 )

Change subject: google/trogdor: Remove GPIO_AP_SUSPEND_L
......................................................................

Patch Set 2: Code-Review+1

[Julius Werner (Code Review)]

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43471 )

Change subject: google/trogdor: Remove GPIO_AP_SUSPEND_L
......................................................................

google/trogdor: Remove GPIO_AP_SUSPEND_L

This pin has been removed from recent revisions (or at least moved to a
pin that's not controlled like a normal GPIO). It has also never been
used on older ones (I think?). The same GPIO is now used as a SKU ID
pin, so make sure we're not incorrectly configuring it as an output
(although sku_id() overrides that later anyway, but it's still
incorrect).

BUG=b:160754995

Signed-off-by: Julius Werner 
Change-Id: I6e0d56e230d0bef172d7b78cc48263e9b6f059de
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43471
Reviewed-by: Douglas Anderson 
Reviewed-by: Philip Chen 
Reviewed-by: Bob Moragues 
Reviewed-by: EricR Lai 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/trogdor/board.h
M src/mainboard/google/trogdor/chromeos.c
2 files changed, 0 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Philip Chen: Looks good to me, approved
  Douglas Anderson: Looks good to me, but someone else must approve
  EricR Lai: Looks good to me, approved
  Bob Moragues: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/trogdor/board.h b/src/mainboard/google/trogdor/board.h
index 63d03db..cab4403 100644
--- a/src/mainboard/google/trogdor/board.h
+++ b/src/mainboard/google/trogdor/board.h
@@ -9,7 +9,6 @@

#define GPIO_EC_IN_RW	GPIO(118)
 #define GPIO_AP_EC_INT	GPIO(94)
-#define GPIO_AP_SUSPEND	GPIO(20)
 #define GPIO_WP_STATE	GPIO(42)
 #define GPIO_H1_AP_INT	(CONFIG(TROGDOR_REV0) ? GPIO(21) : GPIO(42))
 #define GPIO_SD_CD_L	GPIO(69)
diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c
index 9360928..9c45dfe 100644
--- a/src/mainboard/google/trogdor/chromeos.c
+++ b/src/mainboard/google/trogdor/chromeos.c
@@ -14,7 +14,6 @@
 {
    gpio_input_pullup(GPIO_EC_IN_RW);
    gpio_input_pullup(GPIO_AP_EC_INT);
-	gpio_output(GPIO_AP_SUSPEND, 1);
    gpio_input(GPIO_WP_STATE);
    gpio_input_pullup(GPIO_SD_CD_L);
    gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP);