Attention is currently required from: Karthik Ramasubramanian, Kun Liu, Shelley Chen, Subrata Banik, Sumeet R Pawnikar.
wu kai has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83304?usp=email )
Change subject: mb/google/brox/var/lotso: Update DTT settings for thermal control
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brox/variants/lotso/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83304/comment/9a80f9e8_22700c6a?usp... :
PS3, Line 126: 12000
Please share the reason for changing this to lower value, ie. from 15W to 12W.
The project requirement is 12W, we don't need to set pl1 to 15w,which will cause the skin temperature to be worse
https://review.coreboot.org/c/coreboot/+/83304/comment/85d7162b_4c688bea?usp... :
PS3, Line 134: 25000
Share details on lowering the PL2 Max and Min values from 55W to 25W. […]
When the CPU is working, there will be a turbo time. The higher the PL2 setting, the shorter the turbo time. Both the PL2 value and the turbo time will affect the benchmark score. I have done some verification, PL2 set at 25 is the highest run score
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83304?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67e16a2596884d501273a5787119406dff7a20f9
Gerrit-Change-Number: 83304
Gerrit-PatchSet: 3
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dengwu Yu
yudengwu@huaqin.corp-partner.google.com
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-CC: wu kai
wukai8@huaqin.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 05 Jul 2024 02:04:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com