Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42745 )
Change subject: soc/intel: Configure PAVP at compile-time ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42745/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42745/5//COMMIT_MSG@11 PS5, Line 11:
FSP defaults it to enabled. […]
I don’t know the reason of disabling it either, but please mention it in the commit message. Even better, add a separate commit before this one, which enables it for Jasper Lake, and then it’s not hidden in this commit.
https://review.coreboot.org/c/coreboot/+/42745/5/src/soc/intel/common/Kconfi... File src/soc/intel/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/42745/5/src/soc/intel/common/Kconfi... PS5, Line 33: config PAVP : bool "Enable PAVP (Protected Audio-Video Path) support" : default y : help : Protected Audio-Video Path is an Intel technology used to enforce : digital rights protections on multimedia content. : : Set this option to n to disable support
Done? It may not merit inclusion, but I noticed that between CSME 11.0 and 11.8 (1. […]
Thank you for extending the description.
-
Paul Menzel (Code Review)