Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73899 )
Change subject: mb/google/brya/acpi: Pass GPS_FUNC_SUPPORT as 8 byte buffer ......................................................................
mb/google/brya/acpi: Pass GPS_FUNC_SUPPORT as 8 byte buffer
Currently the value was being truncated to 4 bytes. Change so that the full 8 byte value is passed.
TEST=verified function returns expected value using acpiexec BUG=b:271938907 Signed-off-by: Tarun Tuli taruntuli@google.com
Change-Id: Icfc775de680e328a2b240595223d7098fee3dc3b Reviewed-on: https://review.coreboot.org/c/coreboot/+/73899 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com --- M src/mainboard/google/brya/acpi/gps.asl 1 file changed, 20 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/acpi/gps.asl b/src/mainboard/google/brya/acpi/gps.asl index 2e07a67..36bccc1 100644 --- a/src/mainboard/google/brya/acpi/gps.asl +++ b/src/mainboard/google/brya/acpi/gps.asl @@ -27,7 +27,7 @@ { Case (GPS_FUNC_SUPPORT) { - Return (ITOB( + Return (LTOB( (1 << GPS_FUNC_SUPPORT) | (1 << GPS_FUNC_GETCALLBACKS) | (1 << GPS_FUNC_PSHARESTATUS) |