[M] Change in coreboot[master]: mb/google/rex: Configure ISH GPIO's based on FW_CONFIG

[Bernardo Perez Priego (Code Review)]

Attention is currently required from: Jamie Ryu, Jay Patel, Kapil Porwal, Li1 Feng, Subrata Banik, Tarun Tuli, Wonkyu Kim.

Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75525?usp=email )

Change subject: mb/google/rex: Configure ISH GPIO's based on FW_CONFIG
......................................................................

Patch Set 8:

(4 comments)

File src/mainboard/google/rex/variants/rex0/fw_config.c:

https://review.coreboot.org/c/coreboot/+/75525/comment/ab6baf91_f869cfba :
PS8, Line 104: 1
> what does `1` refer to here?

I assumed that this CBI should be the mechanism to determine if Proto1 or Proto2.
If this should not be the way, could you please suggest any other method to differentiate them?

https://review.coreboot.org/c/coreboot/+/75525/comment/f4ba096b_0f4c9711 :
PS8, Line 104:  {
> why brace for single line statement ?

Acknowledged

https://review.coreboot.org/c/coreboot/+/75525/comment/8741ab96_3355f497 :
PS8, Line 107: 2
> what does `2` refer to here?

Same as above comment.

https://review.coreboot.org/c/coreboot/+/75525/comment/ec7013ef_90c691b8 :
PS8, Line 111: printk(BIOS_ERR, "Unknown Board Version for ISH.\n");
> What happens when there is board version is unknown?  […]

I assumed that it would not configure any GPIO pin if board was not determined.