Attention is currently required from: David Hendricks, Rocky Phagura, Arthur Heymans. Hello build bot (Jenkins), Nico Huber, Jonathan Zhang, David Hendricks, Rocky Phagura, Angel Pons, Arthur Heymans, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52518
to look at the new patch set (#4).
Change subject: src/cpu/x86/smm: remove debug message; not thread safe ......................................................................
src/cpu/x86/smm: remove debug message; not thread safe
This patch removes a call to console_init() and debug print message since the code is not thread safe. This prevents system hangs (soft hangs) while in SMM if user drops in a new SOC with more cores or another socket or as a result of bad configuration. Console is already initialized after the lock has been acquired so this does not affect any other functionality.
Tested on DeltaLake mainboard with SMM enabled and 52 CPU threads.
Change-Id: I7e8af35d1cde78b327144b6a9da528ae7870e874 Signed-off-by: Rocky Phagura rphagura@fb.com --- M src/cpu/x86/smm/smm_module_handler.c 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/52518/4