Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik.
Jayvik Desai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83975?usp=email )
Change subject: soc/intel/alderlake: Refactor eSOL for late CSE sync text message
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/83975/comment/f5f4b373_62e7f11e?usp... :
PS1, Line 479: CONFIG(MAINBOARD_HAS_EARLY_LIBGFXINIT))
maybe we can use the recently implemented unified eSOL config for this ? ```CHROMEOS_ENABLE_ESOL```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83975?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c7d4475ed5cf6888df1beebab0641ee4203b497
Gerrit-Change-Number: 83975
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 20 Aug 2024 06:22:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No