Attention is currently required from: Zheng Bao.
Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/85466?usp=email
to review the following change.
Change subject: amdfwtool: Set address mode of BIOS binary as context defines ......................................................................
amdfwtool: Set address mode of BIOS binary as context defines
TEST=Binary identical test on platforms before mendocino Tested on Skyrim
Change-Id: I9c2f2983d03c913b28fbd87aa0925a32a4649d62 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/85466/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 50589dc..e8740b5 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -1534,10 +1534,8 @@ exit(1); }
- biosdir->entries[count].source = - RUN_CURRENT_MODE(*ctx, AMD_ADDR_REL_BIOS); - biosdir->entries[count].address_mode = - SET_ADDR_MODE(biosdir, AMD_ADDR_REL_BIOS); + biosdir->entries[count].address_mode = SET_ADDR_MODE_BY_TABLE(biosdir); + biosdir->entries[count].source = RUN_CURRENT(*ctx);
adjust_current_pointer(ctx, bytes, 0x100U); break;