Attention is currently required from: Eric Lai, Jian Tong, Kun Liu, Paul Menzel, Shelley Chen, Wentao Qin.
Karthik Ramasubramanian has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/82573?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox/var/lotso: Update gpio setting
......................................................................
Patch Set 16:
(1 comment)
File src/mainboard/google/brox/variants/lotso/gpio.c:
https://review.coreboot.org/c/coreboot/+/82573/comment/60e0dad6_78c99cda?usp... :
PS16, Line 37: LOCK_CONFIG
Should we use the LOCK variant only from RO such that RW cannot overwrite the pad config? If so then here we are using it from RW. Or is the intentions to lock the config such that OS cannot overwrite it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82573?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13485cc7ccd8b15352f5e21ad9336aa2b3d35749
Gerrit-Change-Number: 82573
Gerrit-PatchSet: 16
Gerrit-Owner: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dengwu Yu
yudengwu@huaqin.corp-partner.google.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Attention: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 03 Jun 2024 15:53:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No