Attention is currently required from: Angel Pons, Kyösti Mälkki, Elyes Haouas, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69339 )
Change subject: Revert "mb/aopen/dxplplusu: Remove board" ......................................................................
Patch Set 3:
(10 comments)
File src/northbridge/intel/e7505/northbridge.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162880): https://review.coreboot.org/c/coreboot/+/69339/comment/f961c427_0ab54e79 PS3, Line 72: if (dev->path.type == DEVICE_PATH_DOMAIN) { braces {} are not necessary for any arm of this statement
File src/northbridge/intel/e7505/raminit.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162880): https://review.coreboot.org/c/coreboot/+/69339/comment/449bb3c9_15f3ad57 PS3, Line 175: while (i--) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162880): https://review.coreboot.org/c/coreboot/+/69339/comment/117892b7_45956a10 PS3, Line 696: BUG(); Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162880): https://review.coreboot.org/c/coreboot/+/69339/comment/84df1650_3711ae47 PS3, Line 1187: if (!(dimm_mask & (1 << i))) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162880): https://review.coreboot.org/c/coreboot/+/69339/comment/0c211f29_95587280 PS3, Line 1204: if (value != ERROR_SCHEME_ECC) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162880): https://review.coreboot.org/c/coreboot/+/69339/comment/2f7b214d_c35827de PS3, Line 1274: if (sdram_width.side1 == 4) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162880): https://review.coreboot.org/c/coreboot/+/69339/comment/1743db65_23e778d3 PS3, Line 1278: if (sdram_width.side2 == 4) { braces {} are not necessary for single statement blocks
File src/southbridge/intel/i82801dx/i82801dx.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162880): https://review.coreboot.org/c/coreboot/+/69339/comment/55b534a4_40ac9a24 PS3, Line 55: if (!dev->enabled) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162880): https://review.coreboot.org/c/coreboot/+/69339/comment/faa83beb_99c18d74 PS3, Line 58: if (new_disable_mask != cur_disable_mask) { braces {} are not necessary for single statement blocks
File src/southbridge/intel/i82801dx/lpc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162880): https://review.coreboot.org/c/coreboot/+/69339/comment/273a8578_ca2b55e8 PS3, Line 99: switch (pwr_on) that open brace { should be on the previous line
-
build bot (Jenkins) (Code Review)