Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Nico Huber, Ronak Kanabar.
Subrata Banik has posted comments on this change by Ronak Kanabar. ( https://review.coreboot.org/c/coreboot/+/82781?usp=email )
Change subject: intel/alderlake/Kconfig: Use vendorcode headers for Client ADL-N FSP
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/82781/comment/71c4da29_67b79410?usp... :
PS4, Line 119: select HAVE_INTEL_FSP_REPO if FSP_TYPE_IOT
Currently none of the ADL-N boards select FSP_TYPE_IOT. Do we know if this is
correct or rather an oversight because it wasn't necessary before?
You are correct, because all ADL-N boards are coming from the Google ChromeOS project, where we use the client FSP. It is possible that IOT uses of coreboot are not upstreaming their code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82781?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1ffcc3f284c213ff0533de3a0e228aacf523b380
Gerrit-Change-Number: 82781
Gerrit-PatchSet: 4
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Brandon Weeks
bweeks@google.com
Gerrit-CC: Federico Amedeo Izzo
federico@izzo.pro
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Tue, 04 Jun 2024 03:46:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de