Attention is currently required from: Varshit B Pandya, Subrata Banik, Maulik V Vaghela, Paul Menzel, Sugnan Prabhu S, Tim Wawrzynczak.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61020 )
Change subject: driver/wifi: Add _DSM method for DDRRFIM
......................................................................
Patch Set 23: Code-Review+1
(2 comments)
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/61020/comment/ed4d1a60_53d16bba
PS23, Line 157: bool *is_cnvi_ddr_rfim_enabled = NULL;
: is_cnvi_ddr_rfim_enabled = (bool *)ptr;
: acpigen_write_return_integer(*is_cnvi_ddr_rfim_enabled);
nit: I would simplify this to:
```
const bool is_cnvi_ddr_rfim_enabled = *(bool *)ptr;
acpigen_write_return_integer(is_cnvi_ddr_rfim_enabled ? 1 : 0);
```
https://review.coreboot.org/c/coreboot/+/61020/comment/3bfedbc0_7d86eec6
PS23, Line 540: if (dev)
`if (dev && config)`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61020
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I217b736df3d4224a6732d1941a160abcddbd8f37
Gerrit-Change-Number: 61020
Gerrit-PatchSet: 23
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Wed, 23 Mar 2022 15:29:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment