Attention is currently required from: Henry Sun, Karthik Ramasubramanian.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52565 )
Change subject: mb/google/dedede/var/galith: Support Wifi SAR for DVT phase
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/variants/galtic/variant.c:
https://review.coreboot.org/c/coreboot/+/52565/comment/01cdd680_501e5ce7
PS1, Line 8: if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_DISABLED)))
: return "wifi_sar-galtic.hex";
If that is the case, why can't we just return "wifi_sar-galtic.hex" for now. […]
that's right, this modification is to consider upgrading different cases in the future and for minimum modification,
if we have other define method for suport more wifi SAR later, we can only return wifi_sar-galtic.hex in this case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bb76c207ef033f81ecdd57849535b8ac8d13ae
Gerrit-Change-Number: 52565
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 28 Apr 2021 02:34:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment