Attention is currently required from: Kevin Chiu, chris wang, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50240 )
Change subject: soc/amd/picasso: add UPD for RV2 USB3 phy setting adjust
......................................................................
Patch Set 13: Code-Review+2
(1 comment)
File src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb:
https://review.coreboot.org/c/coreboot/+/50240/comment/261e872a_a33e4530
PS10, Line 138: "0"
Yes, it can be setting in the variant, but for dalboz or trembyle Dali. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50240
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d5f69e840952cc5171af1ce8597628d1bede5cb
Gerrit-Change-Number: 50240
Gerrit-PatchSet: 13
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 05 Feb 2021 02:59:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: chris wang
Chris.Wang@amd.com
Gerrit-MessageType: comment