Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83054?usp=email )
Change subject: mb/google/dedede/var/kracko: Add LTE only daughterboard support ......................................................................
mb/google/dedede/var/kracko: Add LTE only daughterboard support
Add FW_CONFIG for no port LTE skus, and probe LTE port in devicetree.
BUG=b:339534479 BRANCH=firmware-dedede-13606.B TEST=emerge-dedede coreboot chromeos-bootimage flash and check boot log on DUT.
Change-Id: I5235df33a36f3b9472ee8b615e4622f6ee3fb1a4 Signed-off-by: Robert Chen robert.chen@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83054 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/kracko/overridetree.cb M src/mainboard/google/dedede/variants/kracko/ramstage.c 3 files changed, 9 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index bca948e..c38aa73 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -9,6 +9,7 @@ option DB_PORTS_1C_1A_LTE 6 option DB_PORTS_1C 7 option DB_PORTS_1A_HDMI_LTE 8 + option DB_PORTS_LTE 9 end field STYLUS 4 option STYLUS_ABSENT 0 diff --git a/src/mainboard/google/dedede/variants/kracko/overridetree.cb b/src/mainboard/google/dedede/variants/kracko/overridetree.cb index 2c25e60..ae70769 100644 --- a/src/mainboard/google/dedede/variants/kracko/overridetree.cb +++ b/src/mainboard/google/dedede/variants/kracko/overridetree.cb @@ -131,6 +131,7 @@ register "enable_delay_ms" = "20" device usb 2.3 on probe DB_PORTS DB_PORTS_1C_LTE + probe DB_PORTS DB_PORTS_LTE end end chip drivers/usb/acpi @@ -175,6 +176,7 @@ register "group" = "ACPI_PLD_GROUP(2, 2)" device usb 3.3 on probe DB_PORTS DB_PORTS_1C_LTE + probe DB_PORTS DB_PORTS_LTE end end chip drivers/usb/acpi diff --git a/src/mainboard/google/dedede/variants/kracko/ramstage.c b/src/mainboard/google/dedede/variants/kracko/ramstage.c index 459fc77..afd218e 100644 --- a/src/mainboard/google/dedede/variants/kracko/ramstage.c +++ b/src/mainboard/google/dedede/variants/kracko/ramstage.c @@ -24,6 +24,12 @@ cfg->usb2_ports[3].enable = 0; cfg->usb3_ports[3].enable = 0; } + if (fw_config_is_provisioned() && + fw_config_probe(FW_CONFIG(DB_PORTS, DB_PORTS_LTE))) { + /* Disable USB C1 port */ + cfg->usb2_ports[1].enable = 0; + cfg->usb3_ports[1].enable = 0; + } }
void variant_devtree_update(void)