Attention is currently required from: Christian Walter, Johnny Lin, Naresh Solanki, Paul Menzel, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75581?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/xeon_sp/spr: Add chip config to enable x2apic
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/soc/intel/xeon_sp/spr/romstage.c:
https://review.coreboot.org/c/coreboot/+/75581/comment/8bd4e10e_720bfd17 :
PS1, Line 162: /*
: * Let coreboot configure LAPIC based on Kconfig.
: * coreboot currently can only switch from XAPIC to X2APIC,
: * so always select XAPIC mode here.
: */
This comment explains why 0 is a good value.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75581?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81e9f473d0400173afd25278845be5ff34fd7e04
Gerrit-Change-Number: 75581
Gerrit-PatchSet: 1
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 02 Jun 2023 08:58:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment