Attention is currently required from: Patrick Rudolph, Johnny Lin, Christian Walter, Arthur Heymans, Jian-Ming Wang, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70501 )
Change subject: soc/intel/xeon_sp: Add IIO resources via SSDT
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Tim, could you give this a try on DeltaLake? Thanks!
File src/soc/intel/xeon_sp/skx/soc_acpi.c:
https://review.coreboot.org/c/coreboot/+/70501/comment/605064d7_6a729f21
PS1, Line 92: acpigen_write_name("ICRS");
Naming it _CRS directly is actually even better.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70501
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I188090819023ca83f14c4610266d215ba34379b8
Gerrit-Change-Number: 70501
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Sun, 05 Feb 2023 05:01:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment