Change in coreboot[master]: mb/asrock/b85m_pro4: Reduce Super I/O ACPI code

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

16 Jun 2020 16 Jun '20

2:30 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42430 )

Change subject: mb/asrock/b85m_pro4: Reduce Super I/O ACPI code ......................................................................

mb/asrock/b85m_pro4: Reduce Super I/O ACPI code

We only need ACPI for the PS/2 devices.

Change-Id: I4cfad012684264b21284674e8e3713a5d8bb37be Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/acpi/superio.asl 1 file changed, 1 insertion(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/42430/1

diff --git a/src/mainboard/asrock/b85m_pro4/acpi/superio.asl b/src/mainboard/asrock/b85m_pro4/acpi/superio.asl index 4bdb4b9..ee2eabe 100644 --- a/src/mainboard/asrock/b85m_pro4/acpi/superio.asl +++ b/src/mainboard/asrock/b85m_pro4/acpi/superio.asl @@ -1,12 +1,3 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */

-#define SUPERIO_DEV SIO0 -#define SUPERIO_PNP_BASE 0x2e -#define NCT6776_SHOW_PP -#define NCT6776_SHOW_SP1 -#define NCT6776_SHOW_KBC -#define NCT6776_SHOW_HWM - -#undef NCT6776_SHOW_GPIO - -#include <superio/nuvoton/nct6776/acpi/superio.asl> +#include <drivers/pc80/pc/ps2_controller.asl>

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Paul Menzel (Code Review)

16 Jun 16 Jun

3:44 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42430 )

Change subject: mb/asrock/b85m_pro4: Reduce Super I/O ACPI code ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42430/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42430/1//COMMIT_MSG@9 PS1, Line 9: We only need ACPI for the PS/2 devices.

...

… for the Linux kernel to detect them?

What about other OSes?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfad012684264b21284674e8e3713a5d8bb37be Gerrit-Change-Number: 42430 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 16 Jun 2020 15:44:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

4:19 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42430 )

Change subject: mb/asrock/b85m_pro4: Reduce Super I/O ACPI code ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42430/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42430/1//COMMIT_MSG@9 PS1, Line 9: We only need ACPI for the PS/2 devices.

...

...
… for the Linux kernel to detect them? […]

Windows doesn't boot, probably because even iasl complains about the nct6776.asl ACPI code.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfad012684264b21284674e8e3713a5d8bb37be Gerrit-Change-Number: 42430 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 16 Jun 2020 16:19:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Angel Pons (Code Review)

4:19 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42430 )

Change subject: mb/asrock/b85m_pro4: Reduce Super I/O ACPI code ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42430/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42430/1//COMMIT_MSG@9 PS1, Line 9: We only need ACPI for the PS/2 devices.

...

Windows doesn't boot, probably because even iasl complains about the nct6776.asl ACPI code.

(with the original code, that is. didn't test the current code yet)

-- To view, visit https://review.coreboot.org/c/coreboot/+/42430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfad012684264b21284674e8e3713a5d8bb37be Gerrit-Change-Number: 42430 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 16 Jun 2020 16:19:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

18 Jun 18 Jun

10:37 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42430 )

Change subject: mb/asrock/b85m_pro4: Reduce Super I/O ACPI code ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42430/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42430/1//COMMIT_MSG@9 PS1, Line 9: We only need ACPI for the PS/2 devices.

...

(with the original code, that is. […]

I tested it again later, it has problems with machine check exceptions... No idea why though.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfad012684264b21284674e8e3713a5d8bb37be Gerrit-Change-Number: 42430 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 18 Jun 2020 22:37:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

11 Jul 11 Jul

9:51 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42430

to look at the new patch set (#10).

Change subject: mb/asrock/b85m_pro4: Reduce Super I/O ACPI code ......................................................................

mb/asrock/b85m_pro4: Reduce Super I/O ACPI code

We only need ACPI for the PS/2 devices. Plus, the NCT6776 ACPI code makes Windows BSOD with STOP 0xA5 (ACPI_BIOS_ERROR), which is bad.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/42430/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/42430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfad012684264b21284674e8e3713a5d8bb37be Gerrit-Change-Number: 42430 Gerrit-PatchSet: 10 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Felix Held (Code Review)

9:52 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42430 )

Change subject: mb/asrock/b85m_pro4: Reduce Super I/O ACPI code ......................................................................

Patch Set 10: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfad012684264b21284674e8e3713a5d8bb37be Gerrit-Change-Number: 42430 Gerrit-PatchSet: 10 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 11 Jul 2020 21:52:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

10:24 p.m.

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42430 )

Change subject: mb/asrock/b85m_pro4: Reduce Super I/O ACPI code ......................................................................

mb/asrock/b85m_pro4: Reduce Super I/O ACPI code

We only need ACPI for the PS/2 devices. Plus, the NCT6776 ACPI code makes Windows BSOD with STOP 0xA5 (ACPI_BIOS_ERROR), which is bad.

Change-Id: I4cfad012684264b21284674e8e3713a5d8bb37be Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42430 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asrock/b85m_pro4/acpi/superio.asl 1 file changed, 1 insertion(+), 10 deletions(-)

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/42430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfad012684264b21284674e8e3713a5d8bb37be Gerrit-Change-Number: 42430 Gerrit-PatchSet: 11 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1543

days inactive

1568

days old

coreboot-gerrit@coreboot.org

7 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Felix Held (Code Review)
Paul Menzel (Code Review)