Attention is currently required from: Terry Chen, Tim Wawrzynczak, Nick Vaccaro.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63078 )
Change subject: device: change set_resources to WARNING
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63078/comment/fb7b3c82_e7ad3bb1
PS3, Line 7: device: change set_resources to WARNING
Maybe:
device: Demote missing set resources message from error to warnings
https://review.coreboot.org/c/coreboot/+/63078/comment/e5740fc3_56bb5802
PS3, Line 9: While running power_Resume/control that shows "NONE missing set_resources". The message does seem more like a warning , therefore switch to BIOS_WARN instead.
1. Please wrap lines after 72 characters.
2. Please remove the space before the comma.
https://review.coreboot.org/c/coreboot/+/63078/comment/76b136f0_b21070af
PS3, Line 9: shows
shows the error
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7e7923265c84999b97a075f0757e7a8d8963b2d
Gerrit-Change-Number: 63078
Gerrit-PatchSet: 3
Gerrit-Owner: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 24 Mar 2022 08:10:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment