Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58309 )
Change subject: mb/google/guybrush: Re-arrange override speed config ......................................................................
mb/google/guybrush: Re-arrange override speed config
Currently override speed config is applied only for non EM100 cases. For EM100 causes, override speed board version defaults to 0 leading to "comparison of unsigned expression >= 0 is always true" error. Fix this error by defining the override speed config for both EM100 and non-EM100 use-cases.
BUG=None TEST=Build Guybrush for both EM100 and non-EM100 cases.
Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: Id8ee7b01c69c4555d6e6a7b0d5f095ea3aaf3405 --- M src/mainboard/google/guybrush/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/58309/1
diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index e5f1382..489c045 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -111,6 +111,8 @@ config ALT_SPI_SPEED default 0 # 66MHz
+endif # !EM100 + config OVERRIDE_EFS_SPI_SPEED int default 3 if EM100 @@ -127,8 +129,6 @@ Minimum board version starting which the Override EFS SPI Speed configuration has to be applied.
-endif # !EM100 - config VARIANT_DIR default "guybrush" if BOARD_GOOGLE_GUYBRUSH default "nipperkin" if BOARD_GOOGLE_NIPPERKIN