Attention is currently required from: Maximilian Brune.
Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83084?usp=email )
Change subject: include/device_tree.h: Fix function name fdt_node_name
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Sorry, I was confused... I had something else in mind. […]
I think I've found the source of this problem. See `payloads/Kconfig`.
`PAYLOAD_FIT_SUPPORT` only gets defined if `PAYLOAD_NONE` is **not** set, but it is for all architectures except x86. The mentioned configs in configs/ don't configure a payload and thus it's enabled.
So in other words, this code is not build-tested because no payload is configured anywhere.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83084?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I527146df26264a0c3af1ad01c21644d751b80236
Gerrit-Change-Number: 83084
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Thu, 20 Jun 2024 23:36:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org