Attention is currently required from: Evan Green, Ren Kuo, Aseda Aboagye, Tyler Wang, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60185 )
Change subject: mb/google/dedede/var/magolor: Add stylus pen function
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60185/comment/93bc5dd0_aa74a6df
PS1, Line 9: Update devicetree and gpio to handle stylus pen detection.
Please add the documents/source for the implementation. Schematics?
File src/mainboard/google/dedede/variants/magolor/gpio.c:
https://review.coreboot.org/c/coreboot/+/60185/comment/df64acd3_b80bbcd9
PS1, Line 7: ramstage*/
Missing space.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62489bb289b18f9aa0823005224eda3ef5218e03
Gerrit-Change-Number: 60185
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Evan Green
evgreen@chromium.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 17 Dec 2021 09:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment