Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41729 )
Change subject: soc/intel/tigerlake: Select PLATFORM_USES_FSP2_2
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/41729/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41729/6//COMMIT_MSG@10
PS6, Line 10: FSP2.2
Please add space between "FSP" and "2.2"
https://review.coreboot.org/c/coreboot/+/41729/6/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/41729/6/src/soc/intel/tigerlake/fsp...
PS6, Line 322: TODO
Please file a bug for the TODO and remove "TODO:" from the comment, perhaps change comment to "TCSS specific initilization goes here" if this CL will not be adding code there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41729
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15252d2db3f8e75d430b84e86cc5141225a3f981
Gerrit-Change-Number: 41729
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Jul 2020 02:02:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment