Attention is currently required from: Felix Held, Henry Sun, Kangheui Won, Mark Hsieh, Paul Menzel, Shou-Chieh Hsu, Sumeet R Pawnikar, Tarun Tuli.
Baieswara Reddy Sagili has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75662?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa: Configure the external V1p05/Vnn/VnnSx rails for joxer
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
External V1P05 rail should be disabled during S0.
File src/mainboard/google/brya/variants/joxer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75662/comment/db619ba4_5d89daf2 :
PS3, Line 18: .v1p05_enable_bitmap = FIVR_ENABLE_ALL_SX,
External V1P05 rail should be disabled during S0.
like v1p05_enable_bitmap = FIVR_ENABLE_ALL_SX & ~FIVR_ENABLE_S0
please refer b/248249033
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75662?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78d2a885d577f6c1a89ab74c0da7b6544322c0d7
Gerrit-Change-Number: 75662
Gerrit-PatchSet: 3
Gerrit-Owner: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 09 Jun 2023 04:27:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment