Attention is currently required from: Felix Singer, Maciej Pijanowski, Michał Kopeć, Michał Żygowski.
Krystian Hebel has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82672?usp=email )
Change subject: ec/dasharo/ec: add Dasharo features
......................................................................
Patch Set 15: Code-Review+1
(1 comment)
File src/ec/dasharo/ec/dasharo_ec.c:
https://review.coreboot.org/c/coreboot/+/82672/comment/fb5bcaa6_f2d15e23?usp... :
PS10, Line 17: #define DASHARO_EC_BASE 0x0E00
Doesn't seem to be. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82672?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d
Gerrit-Change-Number: 82672
Gerrit-PatchSet: 15
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Comment-Date: Thu, 21 Nov 2024 15:58:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michał Kopeć
michal.kopec@3mdeb.com
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com