HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46204 )
Change subject: mb/lenovo/x201: Convert to ASL 2.0 syntax ......................................................................
mb/lenovo/x201: Convert to ASL 2.0 syntax
Change-Id: I3b553e1b68ee8f236fcab311a076001b94a47975 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/x201/acpi/dock.asl M src/mainboard/lenovo/x201/acpi/gpe.asl M src/mainboard/lenovo/x201/acpi/platform.asl 3 files changed, 24 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/46204/1
diff --git a/src/mainboard/lenovo/x201/acpi/dock.asl b/src/mainboard/lenovo/x201/acpi/dock.asl index 0bf5a25..311e620 100644 --- a/src/mainboard/lenovo/x201/acpi/dock.asl +++ b/src/mainboard/lenovo/x201/acpi/dock.asl @@ -12,18 +12,18 @@ { if (Arg0) { /* connect dock */ - Store (1, \GP28) - Store (1, _SB.PCI0.LPCB.EC.DKR1) - Store (1, _SB.PCI0.LPCB.EC.DKR2) - Store (1, _SB.PCI0.LPCB.EC.DKR3) + \GP28 = 1 + _SB.PCI0.LPCB.EC.DKR1 = 1 + _SB.PCI0.LPCB.EC.DKR2 = 1 + _SB.PCI0.LPCB.EC.DKR3 = 1 } else { /* disconnect dock */ - Store (0, \GP28) - Store (0, _SB.PCI0.LPCB.EC.DKR1) - Store (0, _SB.PCI0.LPCB.EC.DKR2) - Store (0, _SB.PCI0.LPCB.EC.DKR3) + \GP28 = 0 + _SB.PCI0.LPCB.EC.DKR1 = 0 + _SB.PCI0.LPCB.EC.DKR2 = 0 + _SB.PCI0.LPCB.EC.DKR3 = 0 } - Xor(Arg0, _SB.PCI0.LPCB.EC.DKR1, Local0) + Local0 = Arg0 ^ _SB.PCI0.LPCB.EC.DKR1 Return (Local0) }
diff --git a/src/mainboard/lenovo/x201/acpi/gpe.asl b/src/mainboard/lenovo/x201/acpi/gpe.asl index 62e7b37..9984636 100644 --- a/src/mainboard/lenovo/x201/acpi/gpe.asl +++ b/src/mainboard/lenovo/x201/acpi/gpe.asl @@ -5,8 +5,8 @@ Method(_L18, 0, NotSerialized) { /* Read EC register to clear wake status */ - Store(_SB.PCI0.LPCB.EC.WAKE, Local0) + Local0 = _SB.PCI0.LPCB.EC.WAKE /* So that we don't get a warning that Local0 is unused. */ - Increment (Local0) + Local0++ } } diff --git a/src/mainboard/lenovo/x201/acpi/platform.asl b/src/mainboard/lenovo/x201/acpi/platform.asl index b03f45f..44b06c6 100644 --- a/src/mainboard/lenovo/x201/acpi/platform.asl +++ b/src/mainboard/lenovo/x201/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) @@ -56,47 +56,47 @@ */
/* Let's assume we're running at least Windows 2000 */ - Store (2000, OSYS) + OSYS = 2000
If (CondRefOf(_OSI)) { If (_OSI("Windows 2001")) { - Store (2001, OSYS) + OSYS = 2001 }
If (_OSI("Windows 2001 SP1")) { - Store (2001, OSYS) + OSYS = 2001 }
If (_OSI("Windows 2001 SP2")) { - Store (2002, OSYS) + OSYS = 2002 }
If (_OSI("Windows 2001.1")) { - Store (2001, OSYS) + OSYS = 2001 }
If (_OSI("Windows 2001.1 SP1")) { - Store (2001, OSYS) + OSYS = 2001 }
If (_OSI("Windows 2006")) { - Store (2006, OSYS) + OSYS = 2006 }
If (_OSI("Windows 2006.1")) { - Store (2006, OSYS) + OSYS = 2006 }
If (_OSI("Windows 2006 SP1")) { - Store (2006, OSYS) + OSYS = 2006 }
If (_OSI("Windows 2009")) { - Store (2009, OSYS) + OSYS = 2009 }
If (_OSI("Windows 2012")) { - Store (2012, OSYS) + OSYS = 2012 } } }
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46204
to look at the new patch set (#2).
Change subject: mb/lenovo/x201: Convert to ASL 2.0 syntax ......................................................................
mb/lenovo/x201: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are identical.
Change-Id: I3b553e1b68ee8f236fcab311a076001b94a47975 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/x201/acpi/dock.asl M src/mainboard/lenovo/x201/acpi/gpe.asl M src/mainboard/lenovo/x201/acpi/platform.asl 3 files changed, 24 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/46204/2
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46204 )
Change subject: mb/lenovo/x201: Convert to ASL 2.0 syntax ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46204 )
Change subject: mb/lenovo/x201: Convert to ASL 2.0 syntax ......................................................................
mb/lenovo/x201: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are identical.
Change-Id: I3b553e1b68ee8f236fcab311a076001b94a47975 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46204 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/x201/acpi/dock.asl M src/mainboard/lenovo/x201/acpi/gpe.asl M src/mainboard/lenovo/x201/acpi/platform.asl 3 files changed, 24 insertions(+), 24 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/lenovo/x201/acpi/dock.asl b/src/mainboard/lenovo/x201/acpi/dock.asl index 0bf5a25..311e620 100644 --- a/src/mainboard/lenovo/x201/acpi/dock.asl +++ b/src/mainboard/lenovo/x201/acpi/dock.asl @@ -12,18 +12,18 @@ { if (Arg0) { /* connect dock */ - Store (1, \GP28) - Store (1, _SB.PCI0.LPCB.EC.DKR1) - Store (1, _SB.PCI0.LPCB.EC.DKR2) - Store (1, _SB.PCI0.LPCB.EC.DKR3) + \GP28 = 1 + _SB.PCI0.LPCB.EC.DKR1 = 1 + _SB.PCI0.LPCB.EC.DKR2 = 1 + _SB.PCI0.LPCB.EC.DKR3 = 1 } else { /* disconnect dock */ - Store (0, \GP28) - Store (0, _SB.PCI0.LPCB.EC.DKR1) - Store (0, _SB.PCI0.LPCB.EC.DKR2) - Store (0, _SB.PCI0.LPCB.EC.DKR3) + \GP28 = 0 + _SB.PCI0.LPCB.EC.DKR1 = 0 + _SB.PCI0.LPCB.EC.DKR2 = 0 + _SB.PCI0.LPCB.EC.DKR3 = 0 } - Xor(Arg0, _SB.PCI0.LPCB.EC.DKR1, Local0) + Local0 = Arg0 ^ _SB.PCI0.LPCB.EC.DKR1 Return (Local0) }
diff --git a/src/mainboard/lenovo/x201/acpi/gpe.asl b/src/mainboard/lenovo/x201/acpi/gpe.asl index 62e7b37..9984636 100644 --- a/src/mainboard/lenovo/x201/acpi/gpe.asl +++ b/src/mainboard/lenovo/x201/acpi/gpe.asl @@ -5,8 +5,8 @@ Method(_L18, 0, NotSerialized) { /* Read EC register to clear wake status */ - Store(_SB.PCI0.LPCB.EC.WAKE, Local0) + Local0 = _SB.PCI0.LPCB.EC.WAKE /* So that we don't get a warning that Local0 is unused. */ - Increment (Local0) + Local0++ } } diff --git a/src/mainboard/lenovo/x201/acpi/platform.asl b/src/mainboard/lenovo/x201/acpi/platform.asl index b03f45f..44b06c6 100644 --- a/src/mainboard/lenovo/x201/acpi/platform.asl +++ b/src/mainboard/lenovo/x201/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0) @@ -56,47 +56,47 @@ */
/* Let's assume we're running at least Windows 2000 */ - Store (2000, OSYS) + OSYS = 2000
If (CondRefOf(_OSI)) { If (_OSI("Windows 2001")) { - Store (2001, OSYS) + OSYS = 2001 }
If (_OSI("Windows 2001 SP1")) { - Store (2001, OSYS) + OSYS = 2001 }
If (_OSI("Windows 2001 SP2")) { - Store (2002, OSYS) + OSYS = 2002 }
If (_OSI("Windows 2001.1")) { - Store (2001, OSYS) + OSYS = 2001 }
If (_OSI("Windows 2001.1 SP1")) { - Store (2001, OSYS) + OSYS = 2001 }
If (_OSI("Windows 2006")) { - Store (2006, OSYS) + OSYS = 2006 }
If (_OSI("Windows 2006.1")) { - Store (2006, OSYS) + OSYS = 2006 }
If (_OSI("Windows 2006 SP1")) { - Store (2006, OSYS) + OSYS = 2006 }
If (_OSI("Windows 2009")) { - Store (2009, OSYS) + OSYS = 2009 }
If (_OSI("Windows 2012")) { - Store (2012, OSYS) + OSYS = 2012 } } }
-
HAOUAS Elyes (Code Review) -
Michael Niewöhner (Code Review)