Hello Chris Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44364
to review the following change.
Change subject: mb/google/zork: update telemetry settings for woomax ......................................................................
mb/google/zork: update telemetry settings for woomax
update telemetry value with the SDLE test result.
BUG=b:158964769 BRANCH=none TEST=emerge-zork coreboot
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: Ic419ca5ca00e4e8602dbc12212a8a63ed3657e02 --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/44364/1
diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb index 557e032..1d4edc2 100644 --- a/src/mainboard/google/zork/variants/woomax/overridetree.cb +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -16,9 +16,9 @@ register "stapm_time_constant" = "200" #second register "sustained_power_limit" = "15000" #mw
- register "telemetry_vddcr_vdd_slope" = "71222" #mA + register "telemetry_vddcr_vdd_slope" = "102586" #mA register "telemetry_vddcr_vdd_offset" = "0" - register "telemetry_vddcr_soc_slope" = "28977" #mA + register "telemetry_vddcr_soc_slope" = "26967" #mA register "telemetry_vddcr_soc_offset" = "0"
# End : OPN Performance Configuration
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44364 )
Change subject: mb/google/zork: update telemetry settings for woomax ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44364 )
Change subject: mb/google/zork: update telemetry settings for woomax ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44364/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44364/1//COMMIT_MSG@9 PS1, Line 9: SDLE What is SDLE?
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44364 )
Change subject: mb/google/zork: update telemetry settings for woomax ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44364/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44364/1//COMMIT_MSG@9 PS1, Line 9: SDLE
What is SDLE?
a electrical test for qualify hardware power design.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44364 )
Change subject: mb/google/zork: update telemetry settings for woomax ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44364/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44364/1//COMMIT_MSG@9 PS1, Line 9: SDLE
a electrical test for qualify hardware power design.
Ack
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44364 )
Change subject: mb/google/zork: update telemetry settings for woomax ......................................................................
mb/google/zork: update telemetry settings for woomax
update telemetry value with the SDLE test result.
BUG=b:158964769 BRANCH=none TEST=emerge-zork coreboot
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: Ic419ca5ca00e4e8602dbc12212a8a63ed3657e02 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44364 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb index f27cf6f..bebcc25 100644 --- a/src/mainboard/google/zork/variants/woomax/overridetree.cb +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -16,9 +16,9 @@ register "stapm_time_constant" = "200" #second register "sustained_power_limit" = "15000" #mw
- register "telemetry_vddcr_vdd_slope" = "71222" #mA + register "telemetry_vddcr_vdd_slope" = "102586" #mA register "telemetry_vddcr_vdd_offset" = "0" - register "telemetry_vddcr_soc_slope" = "28977" #mA + register "telemetry_vddcr_soc_slope" = "26967" #mA register "telemetry_vddcr_soc_offset" = "0"
# End : OPN Performance Configuration
-
Aaron Durbin (Code Review) -
chris wang (Code Review)
-
Furquan Shaikh (Code Review)
-
Paul Menzel (Code Review)