Attention is currently required from: Henry Sun, Paul Menzel, Paul2 Huang.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59856 )
Change subject: mb/google/octopus: add ALC5682I-VS to be supported in the SSFC
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/c/coreboot/+/59856/comment/5d092da9_d0f665f1
PS11, Line 216: printk(BIOS_INFO, "enable RT5682 VS.\n");
Somehow we can move the same condition checks out of three statements above into one but will introduce one nested level and near to 80 chars so I don't make this comment to do this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59856
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80be12d88e100ce8586371fc49b36447859e24f8
Gerrit-Change-Number: 59856
Gerrit-PatchSet: 11
Gerrit-Owner: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Fri, 10 Dec 2021 08:01:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment