build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/#/c/30414/2/src/mainboard/facebook/fbg1701/irqro... File src/mainboard/facebook/fbg1701/irqroute.h:
https://review.coreboot.org/#/c/30414/2/src/mainboard/facebook/fbg1701/irqro... PS2, Line 40: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/30414/2/src/mainboard/facebook/fbg1701/irqro... PS2, Line 62: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/30414/2/src/soc/intel/braswell/smbus.c File src/soc/intel/braswell/smbus.c:
https://review.coreboot.org/#/c/30414/2/src/soc/intel/braswell/smbus.c@69 PS2, Line 69: if ((val & SMBHSTSTS_HOST_BUSY)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/30414/2/src/soc/intel/braswell/smbus.c@135 PS2, Line 135: for (bytes_write=0; bytes_write < bytes; bytes_write++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/30414/2/src/soc/intel/braswell/smbus.c@156 PS2, Line 156: if (bytes_write+1 < bytes) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/30414/2/src/soc/intel/braswell/smbus.c@169 PS2, Line 169: else else should follow close brace '}'
https://review.coreboot.org/#/c/30414/2/src/soc/intel/braswell/smbus.c@263 PS2, Line 263: else else should follow close brace '}'
-
build bot (Jenkins) (Code Review)