Change in coreboot[master]: mb/qemu-i440fx/memmap: Add warning when falling back to CMOS infos

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43446 )

Change subject: mb/qemu-i440fx/memmap: Add warning when falling back to CMOS infos
......................................................................

mb/qemu-i440fx/memmap: Add warning when falling back to CMOS infos

Change-Id: Iefac6fd45791cf6a051450b41046f7e7ebc1dc41
Signed-off-by: Nico Huber 
---
M src/mainboard/emulation/qemu-i440fx/memmap.c
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/43446/1

diff --git a/src/mainboard/emulation/qemu-i440fx/memmap.c b/src/mainboard/emulation/qemu-i440fx/memmap.c
index 2f8a4f8..b30b381 100644
--- a/src/mainboard/emulation/qemu-i440fx/memmap.c
+++ b/src/mainboard/emulation/qemu-i440fx/memmap.c
@@ -3,6 +3,7 @@
 #include <cbmem.h>
 #include <arch/io.h>
 #include <arch/romstage.h>
+#include <console/console.h>
 #include "memory.h"
 #include "fw_cfg.h"

@@ -44,8 +45,10 @@
    uintptr_t top = 0;

top = fw_cfg_tolud();
-	if (!top)
+	if (!top) {
+		printk(BIOS_WARNING, "QEMU: Falling back to RAM info in CMOS\n");
    	top = (uintptr_t)qemu_get_memory_size() * 1024;
+	}

return (void *)top;
 }

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43446 )

Change subject: mb/qemu-i440fx/memmap: Add warning when falling back to CMOS infos
......................................................................

Patch Set 1: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43446 )

Change subject: mb/qemu-i440fx/memmap: Add warning when falling back to CMOS infos
......................................................................

mb/qemu-i440fx/memmap: Add warning when falling back to CMOS infos

Change-Id: Iefac6fd45791cf6a051450b41046f7e7ebc1dc41
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43446
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/mainboard/emulation/qemu-i440fx/memmap.c
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/emulation/qemu-i440fx/memmap.c b/src/mainboard/emulation/qemu-i440fx/memmap.c
index 2f8a4f8..b30b381 100644
--- a/src/mainboard/emulation/qemu-i440fx/memmap.c
+++ b/src/mainboard/emulation/qemu-i440fx/memmap.c
@@ -3,6 +3,7 @@
 #include <cbmem.h>
 #include <arch/io.h>
 #include <arch/romstage.h>
+#include <console/console.h>
 #include "memory.h"
 #include "fw_cfg.h"

@@ -44,8 +45,10 @@
    uintptr_t top = 0;

top = fw_cfg_tolud();
-	if (!top)
+	if (!top) {
+		printk(BIOS_WARNING, "QEMU: Falling back to RAM info in CMOS\n");
    	top = (uintptr_t)qemu_get_memory_size() * 1024;
+	}

return (void *)top;
 }