Change in coreboot[master]: intel/common/block/memory: Add saving memory info API to common block
Attention is currently required from: Furquan Shaikh, Martin Roth, Selma Bensaid, Tim Wawrzynczak, Subrata Banik, Usha P, Andrey Petrov, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51105 )
Change subject: intel/common/block/memory: Add saving memory info API to common block ......................................................................
Patch Set 9:
(34 comments)
File src/soc/intel/common/block/memory/meminfo.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/872c6070_b8197666 PS9, Line 61: if (channel_info->Status != CHANNEL_PRESENT) suspicious code indentation after conditional statements
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/0b1406aa_48997681 PS9, Line 63: switch (meminfo_hob->MemoryType) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/8b7a79b2_2a458599 PS9, Line 63: switch (meminfo_hob->MemoryType) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/928195f5_67b7a412 PS9, Line 64: case MRC_DDR_TYPE_DDR3: code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/03bb29fb_1d885c94 PS9, Line 64: case MRC_DDR_TYPE_DDR3: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/c0f38729_52a9ce1e PS9, Line 65: ddr_type = MEMORY_TYPE_DDR3; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/cca1749b_c1446a73 PS9, Line 65: ddr_type = MEMORY_TYPE_DDR3; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/4e07c70c_675f94ad PS9, Line 66: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/1302de64_0028d933 PS9, Line 66: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/4611395f_ec70b6c0 PS9, Line 67: case MRC_DDR_TYPE_LPDDR3: code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/666d06ee_e82bbd6c PS9, Line 67: case MRC_DDR_TYPE_LPDDR3: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/95a79061_8bc6e516 PS9, Line 68: ddr_type = MEMORY_TYPE_LPDDR3; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/349d5ebc_75dddb20 PS9, Line 68: ddr_type = MEMORY_TYPE_LPDDR3; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/153b8985_2e807712 PS9, Line 69: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/ad9562f2_637514f6 PS9, Line 69: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/da130b7f_c899e87c PS9, Line 70: case MRC_DDR_TYPE_DDR4: code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/63fe25fd_bb45e905 PS9, Line 70: case MRC_DDR_TYPE_DDR4: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/9012f479_9b187a2e PS9, Line 71: ddr_type = MEMORY_TYPE_DDR4; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/90616158_0766dd55 PS9, Line 71: ddr_type = MEMORY_TYPE_DDR4; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/5597a329_e55f63f7 PS9, Line 72: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/2bda5304_3320be62 PS9, Line 72: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/3b9314a2_2f386894 PS9, Line 73: case MRC_DDR_TYPE_LPDDR4: code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/c1a45db2_d3975dae PS9, Line 73: case MRC_DDR_TYPE_LPDDR4: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/6faa0306_714064eb PS9, Line 74: ddr_type = MEMORY_TYPE_LPDDR4; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/5f391fba_84966164 PS9, Line 74: ddr_type = MEMORY_TYPE_LPDDR4; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/e75bc7eb_425c4057 PS9, Line 75: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/49327b59_2c5124df PS9, Line 75: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/07108369_279e88a6 PS9, Line 76: default: code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/bfb8a6a4_d0171abf PS9, Line 77: ddr_type = meminfo_hob->MemoryType; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/3a99dd4e_577ac845 PS9, Line 77: ddr_type = meminfo_hob->MemoryType; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/479aeb40_b5e2ecd4 PS9, Line 78: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/b66d7d9a_528e3f69 PS9, Line 78: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/fba3491e_f303c632 PS9, Line 79: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123904): https://review.coreboot.org/c/coreboot/+/51105/comment/9f430470_0be66c51 PS9, Line 79: } please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)