Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Varshit Pandya, ritul guru.
Nico Huber has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83739?usp=email )
Change subject: soc/amd: add PSP SMI handler stub
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File src/soc/amd/cezanne/smihandler.c:
https://review.coreboot.org/c/coreboot/+/83739/comment/48943fa0_f218cbab?usp... :
PS2, Line 116: psp_smi_handler
oh, looks like i missed the 'in the header part' when reading your comment. […]
:)
File src/soc/amd/common/block/psp/psp_smm.c:
https://review.coreboot.org/c/coreboot/+/83739/comment/851fbbfe_999426e0?usp... :
PS2, Line 94: configure_psp_smi();
it's not necessary to do this in smm; however the next patch CB:83740 adds the enable_psp_smi call w […]
Ack. Just checking that this wasn't a mistake.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83739?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I65989ff529d728cd9d2cd60b384295417bef77ad
Gerrit-Change-Number: 83739
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 02 Aug 2024 17:04:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de