[M] Change in coreboot[master]: mb/google/link: rework TP/TS ACPI to add support for new Windows I2C ...

[Nico Huber (Code Review)]

Attention is currently required from: CoolStar, Martin Roth, Matt DeVillier, Stefan Reinauer.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76159?usp=email )

Change subject: mb/google/link: rework TP/TS ACPI to add support for new Windows I2C driver
......................................................................

Patch Set 7:

(8 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/76159/comment/61f128c6_bf513471 :
PS7, Line 7: to add support 
If you'd drop `to add support `, it would fit the line without
losing valuable information.

https://review.coreboot.org/c/coreboot/+/76159/comment/8e4decf0_c8c05f29 :
PS7, Line 24: or changing display resolutions with the i2c driver attached.
What happens when the touchpad is used while an external
display is attached/probed?

I would further test how DP cascades behave, e.g. daisy-
chained displays, multi-port docking hubs...

File src/mainboard/google/link/acpi/mainboard.asl:

https://review.coreboot.org/c/coreboot/+/76159/comment/227948fc_495b0b8b :
PS7, Line 49: ){
Missing space before `{`. Same below.

https://review.coreboot.org/c/coreboot/+/76159/comment/c8a838eb_0b68f281 :
PS7, Line 50: LINK
Can't find LINK here: https://uefi.org/acpi_id_list
If it's not going to be registered, we should find a propper way to identify
a custom device. If necessary at all, it seems possible that the Atmel IDs
would already suffice? Could you link to the code of the Windows driver?

https://review.coreboot.org/c/coreboot/+/76159/comment/42b3b2b5_9238e17f :
PS7, Line 51: 		Method (_STA, 0, NotSerialized)  // _STA: Status
            : 		{
            : 			Return (0x0F)
            : 		}
This seems superfluous, 0xf should be the default w/o _STA. Same below.

https://review.coreboot.org/c/coreboot/+/76159/comment/a4b0800a_a5646730 :
PS7, Line 56: MMIO
I don't see this being used, I guess that would be the Windows driver?
Should this be a _DSM?

https://review.coreboot.org/c/coreboot/+/76159/comment/f39d28cb_7da1d18c :
PS7, Line 62: VGA
Doesn't really matter, but I find VGA a bit confusing. What does it mean
in this context?

https://review.coreboot.org/c/coreboot/+/76159/comment/a594bcbd_906e2a9d :
PS7, Line 82: ISTP
Where is this used? For the OS, ATML0000 already identifies as touchpad.