Change in coreboot[master]: mb/google,intel: Add ChromeOS GPIOs to onboard.h - coreboot-gerrit

11 Nov 2021


      Attention is currently required from: Tim Wawrzynczak, Angel Pons.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59000 )
Change subject: mb/google,intel: Add ChromeOS GPIOs to onboard.h
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/butterfly/chromeos.c:
https://review.coreboot.org/c/coreboot/+/59000/comment/7ee5e7e3_aba7354d 
PS4, Line 16: #define DEVMODE_GPIO	54
...
DEVMODE_GPIO is unused
I thought of keeping it, assuming the switch existed but was deprecated from depthcharge. Looking at CB:2359 developer mode switch was always virtual, so I'll remove it.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59000
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia473596e3c9a75587cd1288c8816bfef66bef82e
Gerrit-Change-Number: 59000
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 11 Nov 2021 13:14:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment