Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69437 )
Change subject: drivers/ipmi/ocp: Fix building with clang ......................................................................
drivers/ipmi/ocp: Fix building with clang
Fix the following warning: error: use of logical '&&' with constant operand [-Werror,-Wconstant-logical-operand]
Change-Id: I9a2f03a0e05088a780ce1e829859421b461032ca Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/ipmi/ocp/ipmi_sel.c 1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/69437/1
diff --git a/src/drivers/ipmi/ocp/ipmi_sel.c b/src/drivers/ipmi/ocp/ipmi_sel.c index b10755f..f7605ec 100644 --- a/src/drivers/ipmi/ocp/ipmi_sel.c +++ b/src/drivers/ipmi/ocp/ipmi_sel.c @@ -105,7 +105,7 @@ { struct ipmi_config_rsp rsp = {.slot_id = UINT8_MAX};
- if (CONFIG(IPMI_KCS) && CONFIG_BMC_KCS_BASE) { + if (CONFIG(IPMI_KCS) && CONFIG_BMC_KCS_BASE != 0) { if (ipmi_get_board_config(CONFIG_BMC_KCS_BASE, &rsp) != CB_SUCCESS) return UINT8_MAX; }