Attention is currently required from: Nico Huber, Michał Żygowski, Kyösti Mälkki. Hello build bot (Jenkins), Nico Huber, Arthur Heymans, Kyösti Mälkki,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52922
to look at the new patch set (#3).
Change subject: nb/amd/{agesa,pi}: Avoid overflows during DRAM calculation ......................................................................
nb/amd/{agesa,pi}: Avoid overflows during DRAM calculation
Do not use get_dram_base_mask to calculate system DRAM limits. Shift operation around values operating on base and mask were causing overflows and thus incorrect system DRAM limit. Another function returning base and limit in KiB has been developed to avoid data loss.
Keep DRAM high base and limit in calculations only for Trinity where the physical CPU address bits is 48. Although it is almost impossible to have a non-zero value there, the platform would have to support nearly 256GB of RAM.
TEST=boot PC Engines apu1 2GB, apu2 4GB and apu3 2GB and boot Debian with Linux 4.14
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: I3b5c1df96c308ff50c8de104e213219a98f25e10 --- M src/northbridge/amd/agesa/family14/northbridge.c M src/northbridge/amd/agesa/family15tn/northbridge.c M src/northbridge/amd/agesa/family16kb/northbridge.c M src/northbridge/amd/pi/00730F01/northbridge.c 4 files changed, 142 insertions(+), 155 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/52922/3